too many shell scripts in the code's root directory #46

Closed
opened 3 years ago by jahway603 · 2 comments
Collaborator
  • Wanted to log this issue to get feedback from others before making any changes since a new (or not new) user might be confused by all the shell scripts

Proposed changes

  • Create "util" directory in root
  • move "run-after-build.sh" to util
  • move "install.sh" to util
  • Update README.md to let users know about these scripts
  • Optionally create a separate README.me in "util" directory to explain wtf the scripts do
* Wanted to log this issue to get feedback from others before making any changes since a new (or not new) user might be confused by all the shell scripts Proposed changes * Create "util" directory in root * move "run-after-build.sh" to util * move "install.sh" to util * Update README.md to let users know about these scripts * Optionally create a separate README.me in "util" directory to explain wtf the scripts do
Collaborator

From #36

I would like to keep run-after-build.sh since I use it to automate the running of SDL after a successful compile, which is slightly different.

If you move install.sh you need to move a SilentDragonLite.desktop file as well, and to run install.sh properly you will have to cd into util directory to mv SilentDragonLite.desktop into ~/.local/share/applications, I personally don't use it but it is much easier for people to launch SDL by clicking the SDL logo.

This is how the SDL installation process is look like for users:

git clone https://git.hush.is/hush/SilentDragonLite.git && cd SilentDragonLite/ && ./install.sh

Assume the only thing that will change is cd SilentDragonLite/util, I'm OK with that.

From https://git.hush.is/hush/SilentDragonLite/pulls/36 > I would like to keep run-after-build.sh since I use it to automate the running of SDL after a successful compile, which is slightly different. If you move install.sh you need to move a SilentDragonLite.desktop file as well, and to run install.sh properly you will have to `cd` into util directory to `mv` SilentDragonLite.desktop into ~/.local/share/applications, I personally don't use it but it is much easier for people to launch SDL by clicking the SDL logo. This is how the SDL installation process is look like for users: ``` git clone https://git.hush.is/hush/SilentDragonLite.git && cd SilentDragonLite/ && ./install.sh ``` Assume the only thing that will change is `cd SilentDragonLite/util`, I'm OK with that.
Poster
Collaborator

K, from #36 we keep "run-after-build.sh" in the root.

I added more for the .desktop file as this currently exists in the SDL AUR package since a user asked for it a while back. The "Version=1.0" line corresponds to the Desktop Entry Specification documentation. I created these for Arch users for both SilentDragon and SDL

  • Util dir created
  • moved "install.sh" script to util
K, from #36 we keep "run-after-build.sh" in the root. I added more for the .desktop file as this currently exists in the [SDL AUR package](https://aur.archlinux.org/cgit/aur.git/tree/silentdragonlite.desktop?h=silentdragonlite) since a user asked for it a while back. The "Version=1.0" line corresponds to the [Desktop Entry Specification documentation](https://specifications.freedesktop.org/desktop-entry-spec/desktop-entry-spec-latest.html). I created these for Arch users for both [SilentDragon](https://aur.archlinux.org/cgit/aur.git/tree/silentdragon.desktop?h=silentdragon) and SDL * Util dir created * moved "install.sh" script to util
jahway603 closed this issue 3 years ago
Sign in to join this conversation.
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

This issue currently doesn't have any dependencies.

Loading…
There is no content yet.