I was not able to determine how to fix this, so posting this as an issue.
How to reproduce
When you click on Help, the first item states: "Send DenioD Feedback".
The first item there should have Duke's name.
The first item there should mimic the behavior of SD for this functionality.
I was not able to determine how to fix this, so posting this as an issue.
How to reproduce
1. When you click on Help, the first item states: "Send DenioD Feedback".
1. The first item there should have Duke's name.
1. The first item there should mimic the behavior of SD for this functionality.
@jahway603 what about "contact the hush developers" and we use a zaddr which is shared among Hush devs, so that many people can potentially see the feedback? Otherwise it probably gets lost in a wallet.dat somewhere
@jahway603 what about "contact the hush developers" and we use a zaddr which is shared among Hush devs, so that many people can potentially see the feedback? Otherwise it probably gets lost in a wallet.dat somewhere
I just seen you mentioned an issue like this in Telegram and you sez it's on the Gitea, but I can't find it anywhere @onryo . Anyhow, might have a duplicate issue.
I just seen you mentioned an issue like this in Telegram and you sez it's on the Gitea, but I can't find it anywhere @onryo . Anyhow, might have a duplicate issue.
I could fix this if you want to keep it or remove it entirely. Currently, the action is commented out here and won't do anything when clicking:
https://git.hush.is/hush/SilentDragonLite/src/branch/master/src/mainwindow.cpp#L112
The donate function that would call if not commented out is here:
https://git.hush.is/hush/SilentDragonLite/src/branch/master/src/mainwindow.cpp#L899
`getDonationAddr` is defined here and currently set to: `zs1fq9f7vg797qaeac9lyx0njyjmjg4w7m60hwq6lhyhvdcqltl5hdkm8vwx9cxy60ehuuz2x49jxt`
https://git.hush.is/hush/SilentDragonLite/src/branch/master/src/settings.cpp#L365
@fekt@jahway603 let's just delete all the donation related stuff, no idea who even owned that zaddr. If somebody wants to volunteer to get feedback via zaddr, I am fine with that, otherwise just delete it.
@fekt @jahway603 let's just delete all the donation related stuff, no idea who even owned that zaddr. If somebody wants to volunteer to get feedback via zaddr, I am fine with that, otherwise just delete it.
Editor decided to fix some indentation below it I guess.
It's removed and comitted: https://git.hush.is/hush/SilentDragonLite/commit/4efcbc630e9e900236648aa631d01f86d06088ed
Editor decided to fix some indentation below it I guess.
duke
I was not able to determine how to fix this, so posting this as an issue.
How to reproduce
@jahway603 better yet, just delete it
Change "DenioD" to "Duke" in the Help sectionto Delete Feedback section 3 years ago@jahway603 what about "contact the hush developers" and we use a zaddr which is shared among Hush devs, so that many people can potentially see the feedback? Otherwise it probably gets lost in a wallet.dat somewhere
@onryo thoughts on this?
@duke If we're not using the "Send XYZ Feedback" functionality, then it could be removed from code.
I just seen you mentioned an issue like this in Telegram and you sez it's on the Gitea, but I can't find it anywhere @onryo . Anyhow, might have a duplicate issue.
I could fix this if you want to keep it or remove it entirely. Currently, the action is commented out here and won't do anything when clicking:
https://git.hush.is/hush/SilentDragonLite/src/branch/master/src/mainwindow.cpp#L112
The donate function that would call if not commented out is here:
https://git.hush.is/hush/SilentDragonLite/src/branch/master/src/mainwindow.cpp#L899
getDonationAddris defined here and currently set to:zs1fq9f7vg797qaeac9lyx0njyjmjg4w7m60hwq6lhyhvdcqltl5hdkm8vwx9cxy60ehuuz2x49jxthttps://git.hush.is/hush/SilentDragonLite/src/branch/master/src/settings.cpp#L365
@fekt I think we should remove it if we're not using it.
@duke Do we want to use this instead of deleting it?
@fekt @jahway603 let's just delete all the donation related stuff, no idea who even owned that zaddr. If somebody wants to volunteer to get feedback via zaddr, I am fine with that, otherwise just delete it.
It's removed and comitted:
4efcbc630eEditor decided to fix some indentation below it I guess.
@fekt thanks!