Reduce debug.log metadata leakage #80

Open
opened 2 years ago by duke · 2 comments
duke commented 2 years ago
Owner

Most users will never ever look at or use the debug.log, but it contains some sensitive metadata, such as zaddrs and txids in which funds are received. Currently my SDL log file is 3.7MB and over 32000 lines. This is much more history than we need to keep.

  • During SDL shutdown, resize the debug log to have only 200 lines
    • This reduces metadata of already existing log files
  • Prevent log lines like the following:
2022-01-07T00:52:26.587768358-04:00 INFO::Received sapling output to zs1...
2022-01-07T00:52:26.602953398-04:00 INFO::Txid ... belongs to wallet
2022-01-07T01:42:07.252079598-04:00 INFO::Fetching full Tx: ...
2022-01-07T01:42:07.273356888-04:00 INFO::A sapling note was sent to wallet in .. that had a memo

The first item is a change to this repo, but the second item is actually commenting out debug prints in silentdragonlite-cli

Most users will never ever look at or use the debug.log, but it contains some sensitive metadata, such as zaddrs and txids in which funds are received. Currently my SDL log file is 3.7MB and over 32000 lines. This is much more history than we need to keep. - [ ] During SDL shutdown, resize the debug log to have only 200 lines - [ ] This reduces metadata of already existing log files - [x] Prevent log lines like the following: ``` 2022-01-07T00:52:26.587768358-04:00 INFO::Received sapling output to zs1... 2022-01-07T00:52:26.602953398-04:00 INFO::Txid ... belongs to wallet 2022-01-07T01:42:07.252079598-04:00 INFO::Fetching full Tx: ... 2022-01-07T01:42:07.273356888-04:00 INFO::A sapling note was sent to wallet in .. that had a memo ``` The first item is a change to this repo, but the second item is actually commenting out debug prints in silentdragonlite-cli
Poster
Owner

silentdragonlite-cli has been updated to not log these lines and SDL dev branch now uses that code, so the next release of SDL will have that fixed.

silentdragonlite-cli has been updated to not log these lines and SDL `dev` branch now uses that code, so the next release of SDL will have that fixed.
duke commented 1 year ago
Poster
Owner

We have had a release since the change to not log txid's in log lines, so that is fixed in the latest release.

We have had a release since the change to not log txid's in log lines, so that is fixed in the latest release.
duke added the
bug
high priority
labels 1 year ago
Sign in to join this conversation.
No Milestone
No project
No Assignees
1 Participants
Notifications
Due Date

No due date set.

Dependencies

This issue currently doesn't have any dependencies.

Loading…
There is no content yet.