Change default of price feed to OFF #99

Open
opened 1 year ago by duke · 2 comments
duke commented 1 year ago
Owner

It's safer for all users for SDL to not get price data by default. We cannot avoid the fact that even though we are using TLS, the server name is leaked by SNI during the beginning of the TLS handshake and so a network spy (such as a user ISP) knows that a computer is talking to coingecko.com (but not which page is requested).

Users that want price feed data can enable it explicitly via settings.

It's safer for all users for SDL to not get price data by default. We cannot avoid the fact that even though we are using TLS, the server name is leaked by SNI during the beginning of the TLS handshake and so a network spy (such as a user ISP) knows that a computer is talking to coingecko.com (but not which page is requested). Users that want price feed data can enable it explicitly via settings.
duke commented 1 year ago
Poster
Owner

The same popup modal in hush/SilentDragon#106 should be implemented for SDL

The same popup modal in https://git.hush.is/hush/SilentDragon/issues/106 should be implemented for SDL
onryo added the
feature
low priority
labels 1 year ago
Collaborator

I updated in dev branch to default to off: 35e14d53c5

I have not tested with a new wallet, but deleting config file and restarting SDL seems to default it to off. There is still no popup modal yet.

I updated in `dev` branch to default to off: https://git.hush.is/hush/SilentDragonLite/commit/35e14d53c5c154f6439d9972b2b691b1b0f67b33 I have not tested with a new wallet, but deleting config file and restarting SDL seems to default it to off. There is still no popup modal yet.
Sign in to join this conversation.
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

This issue currently doesn't have any dependencies.

Loading…
There is no content yet.