5d37904b9c
Add -Wformat -Wformat-security
8 years ago
2833fb14af
Auto merge of #1291 - daira:decrease-max-headers-results, r=daira
Decrease MAX_HEADERS_RESULTS to 1000. fixes #1289
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
8 years ago
b93c8139e6
Decrease MAX_HEADERS_RESULTS to 160. fixes #1289
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
8 years ago
bcf79c78c5
Change some asserts in equihash.cpp to be static.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
8 years ago
c6a7e897bc
Add mostly-static checks on consistency of Equihash parameters, MAX_HEADERS_RESULTS, and MAX_PROTOCOL_MESSAGE_LENGTH.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
8 years ago
cab581256f
Auto merge of #1292 - bitcartel:zc.v0.11.2.latest_701_rpc_docs, r=daira
Closes #701 by adding documentation about the Payment RPC interface.
@daira Calls which might not make it into z9 are labelled (NOT IN Z9 ALPHA).
8 years ago
cd9d373987
Auto merge of #1260 - str4d:1175-byte-array-manipulation, r=ebfull
Update Equihash implementation to match the Zcash spec
Closes #1175
8 years ago
90b740fd3b
Test conversion between solution indices and minimal representation
8 years ago
5f3f741e47
Add note about zkey and encrypted wallets in z9 alpha.
8 years ago
73f9e32b86
Closes #701 by adding documentation about the Payment RPC interface.
8 years ago
27bd8e4129
Auto merge of #1270 - ThisIsNotOfficialCodeItsJustForks:t1168-fix-optimization-flags, r=daira
Fix inconsistent -O1/-O2, fix libzcash flags, add -fwrapv -fno-strict-aliasing
Closes #1168 . In that ticket I decided the optimization flags for dependencies are out of scope, i.e. we go with whatever the upstream package maintainer chose.
8 years ago
fed866e212
Auto merge of #1262 - ebfull:compressed-proofs, r=ebfull
Implement zkSNARK compression
Implement zkSNARK compression.
The serialization format of zkSNARKs has now been specified in our protocol specification. G1/G2 elements are now compressed into 33 byte and 65 byte formats, repsectively. `MONTGOMERY_OUTPUT` is enabled everywhere to make proving/verifying keys load faster and be consistent with the MPC.
Proofs are now 296 bytes. This PR also updates the proving and verifying keys.
Closes #1103 . Closes #471 .
See also https://github.com/zcash/libsnark/pull/3 and https://github.com/zcash/libsnark/pull/4
8 years ago
07b246988b
Auto merge of #1261 - str4d:892-branch-coverage, r=daira
Coverage report improvements
8 years ago
393b2b7834
Update proving/verifying keys.
8 years ago
decde3864d
Enable MONTGOMERY_OUTPUT everywhere.
8 years ago
6a1653f009
Update libsnark dependency.
8 years ago
ae6b333c75
Perform curve parameter initialization at start of gtest suite.
8 years ago
ea92aba9fe
Move bigint arithmetic implementations to libsnark.
8 years ago
f0dab51cf3
Implement zkSNARK compression.
8 years ago
365845216b
Auto merge of #1268 - ThisIsNotOfficialCodeItsJustForks:t1130-upgrade-libsodium, r=ebfull
Upgrade libsodium for AVX2-detection bugfix.
Upgrades libsodium to bring in an AVX2-detection bugfix (to help with #1130 ).
8 years ago
f4491c51e4
Auto merge of #1248 - rcseacord:rcseacord-patch-4, r=ebfull
Update uint256.h
Addresses load of misaligned address for type 'const uint32_t' #1246
8 years ago
e273f05d10
Remove unnecessary temporary array from Equihash hash generation
8 years ago
6e629886e5
Add another test case based on example in the spec
8 years ago
6c7cc8ebea
update zcash-cli stop message
changed "Bitcoin server stopping" to "Zcash server stopping"
8 years ago
7e556172d9
Auto merge of #1236 - tomrittervg:tomrittervg-comments-1, r=ebfull
Clarify comment about nonce space for Note Encryption
8 years ago
2902ac7ce8
Use libsodium's s < L check, instead checking that libsodium checks that.
8 years ago
36d5f42948
Update NoteEncryption.hpp
8 years ago
28a30f7801
Auto merge of #1254 - ebfull:tx-structure-changes, r=bitcartel
Change memo field size and relocate `ciphertexts` field of JoinSplit description
Closes #1190
Closes #1187
8 years ago
2ee6ed64eb
Add parenthesis around macro value definition
8 years ago
af9898eee5
Auto merge of #1258 - ThisIsNotOfficialCodeItsJustForks:t1251-upstream-anti-dos, r=daira
Pull in some DoS mitigations from upstream
Closes #1251 .
**WARNING: I force pushed**
8 years ago
3d28c86c8e
Auto merge of #1205 - str4d:1199-key-management, r=str4d
Add support for spending keys to the basic key store
Prerequisite for #1197 and #1199 .
8 years ago
a4f4fa8fe9
ASSERT -> EXPECT in test to get more info per test run about future regressions
8 years ago
04dfc3c569
Rework test to check for failure to return a spending key
8 years ago
f5d3d420f6
Add -fwrapv -fno-strict-aliasing; fix libzcash flags.
8 years ago
46ad3c2758
Fix inconsistent optimization flags; single source of truth.
8 years ago
a635d6e995
Upgrade libsodium for AVX2-detection bugfix.
8 years ago
39af39fb85
Auto merge of #1231 - rcseacord:rcseacord-patch-3, r=str4d
Address incorrect use of shared_ptr in test_equihash.cpp
Closes #1228
8 years ago
cdc01fad17
Auto merge of #1230 - rcseacord:rcseacord-patch-1, r=str4d
Address incorrect use of shared_ptr in equihash.cpp
Closes #1214
8 years ago
0d7386916d
Add separate lock for SpendingKey key store operations
8 years ago
c2059f9e09
Remove non-libsnark dependencies and test harness code from coverage reports
Closes #1203
8 years ago
71442d31cf
Add gtest coverage to folders deleted by "make clean"
8 years ago
873625bc85
Add gtest coverage intermediates to list of files deleted by make
8 years ago
6ecb05dd2f
Enable branch coverage in coverage reports
Closes #892
8 years ago
5be6abbf84
Store the Equihash solution in minimal representation in the block header
The genesis blocks and miner tests have been regenerated, because changing the
block header serialisation format changes the block hash, and thus validity.
The Equihash solutions have been removed from the bloom test inputs for
simplicity (block validity is not checked there; only a valid serialisation is
necessary).
8 years ago
9dcea38a6b
net: correctly initialize nMinPingUsecTime
`nMinPingUsecTime` was left uninitialized in CNode.
The correct initialization for a minimum-until-now is int64_t's max value, so initialize it to that.
Thanks @MarcoFalke for noticing.
9 years ago
85e84f5e58
Use network group instead of CNetAddr in final pass to select node to disconnect
9 years ago
b63e75ae12
Fix comment
9 years ago
f1e7e37130
Acquire cs_vNodes before changing refrence counts
9 years ago
75c0598cac
CNodeRef copy constructor and assignment operator
9 years ago
ce94413e03
Return false early if vEvictionCandidates is empty
9 years ago
Taylor Hornby