7703a673ea
Generalize the PushAnchor implementation behavior.
6 years ago
9ea4e387b2
Generalize the PopAnchor implementation behavior.
6 years ago
18322f074c
Introduce support for GetBestAnchor(SAPLING).
6 years ago
2bd59e1473
Rename PushAnchor to PushSproutAnchor.
6 years ago
008f4ee8e7
Rename GetAnchorAt to GetSproutAnchorAt.
6 years ago
8b8d70cad9
Rename DB_ANCHOR to DB_SPROUT_ANCHOR.
6 years ago
30325eebf5
Add primitive implementation of GetSaplingAnchorEnd.
6 years ago
691a3fa2e9
Rename hashReserved to hashSaplingAnchorEnd.
6 years ago
08f0728884
Rename hashAnchor to hashSproutAnchor.
6 years ago
d455828fdc
Specifically describe anchors as Sprout anchors.
6 years ago
28d20bdb11
Rename NullifierType to ShieldedType.
6 years ago
2f23a656fb
Add regression tests and test vectors for Sapling merkle tree
6 years ago
2b002a7e60
Add implementation of Sapling merkle tree
6 years ago
a7cbb8475f
Abstract `uncommitted` and depth personalization for IncrementalMerkleTree.
6 years ago
265eca3f47
Auto merge of #3212 - str4d:2864-sapling-tx-size-limit, r=str4d
Raise 100kB transaction size limit from Sapling activation
Closes #2864 .
6 years ago
8ef1d333b5
Auto merge of #2894 - per-gron:dont-export-unless-needed, r=str4d
Make some globals static that can be
I wrote this patch as part of making a Bazel build system but it really is independent from that so I'm putting this as a separate PR.
External linkage does not help and just encourages sloppy dependencies (ie using symbols only declared in a cpp file in some other cpp file) and can lead to weird issues when there are name collisions.
6 years ago
e1dbec49b7
Add test of Sapling transaction size boundary
6 years ago
892ae945f7
Rework z_sendmany z-address recipient limit
From Sapling, the z-address recipients could require either JSDescriptions or
OutputDescriptions. Instead of trying to give an exact number in the help text,
rely on transaction size estimation to guide user behaviour.
6 years ago
25fee3509a
Rename MAX_TX_SIZE to MAX_TX_SIZE_AFTER_SAPLING
6 years ago
ddcee7e13a
Benchmark the largest valid Sapling transaction in validatelargetx
11130 inputs results in a transaction between 1992301 and 2003431 bytes.
6 years ago
15ec5525e3
Raise 100kB transaction size limit from Sapling activation
Closes #2864 .
6 years ago
d97bfb766b
Auto merge of #3228 - str4d:3058-taddr-encoding-refactor, r=str4d
Refactor t-address encoding
Includes code cherry-picked from the following upstream PRs:
- bitcoin/bitcoin#11117
- bitcoin/bitcoin#11259
- Only the second commit (first is for QT code)
- bitcoin/bitcoin#11167
- Only the first commit (the rest are not part of the t-address encoding refactor).
Part of #3058 . Precursor to #3202 .
6 years ago
2d1a3cf8f5
Auto merge of #3183 - bitcartel:least_authority_issue_d, r=str4d
Closes #3182 - Least Authority Issue D
Prevent undefined behaviour when null pointer is passed in as parameter to function
Includes a backport of bitcoin/bitcoin#10250 .
6 years ago
c7f5d5ce1c
Auto merge of #3227 - str4d:3191-nullifier-macos-fix, r=str4d
Fix -Wstring-plus-int warning on clang
6 years ago
c8f9c87bf1
Implement {Encode,Decode}Destination without CBitcoinAddress
7 years ago
6939c994ef
Remove unused GetKeyID and IsScript methods from CBitcoinAddress
7 years ago
56c43a36bf
Move CBitcoinAddress to base58.cpp
7 years ago
b6be3e88bb
Use CBitcoinAddress wrappers in Zcash-specific code
6 years ago
07444da1db
Introduce wrappers around CBitcoinAddress
This patch removes the need for the intermediary Base58 type
CBitcoinAddress, by providing {Encode,Decode,IsValid}Destination
function that directly operate on the conversion between strings
and CTxDestination.
7 years ago
9e5398686c
Auto merge of #3206 - bitcartel:3194_polymorphic_note_class, r=str4d
Update note classes to be polymorphic
Closes #3194 . Lays foundation for introduction of Sapling notes through refactoring and creation of a class hierarchy for Sprout notes. This PR updates some tests, but otherwise is a no-op.
6 years ago
53fa6f1315
Auto merge of #3179 - bitcartel:backport_transaction_details_in_getblock_v2bitcartel, r=str4d
Add improvements to getblock RPC output
Includes and supercedes #3095 . Includes code cherry-picked from bitcoin/bitcoin#8704 .
6 years ago
0a8d0c25e8
Auto merge of #3220 - Eirik0:3209-fix-CheckTransaction, r=str4d
Implement consensus rules about the number of Spend and Output Descriptions in a transaction
Closes #3209 .
Part of #3065 .
6 years ago
1f9dfbb9f0
Fix -Wstring-plus-int warning on clang
6 years ago
90304c4214
Auto merge of #3213 - str4d:3202-precursor, r=str4d
Upstream encoding cleanups
Cherry-picked from the following upstream PRs:
- bitcoin/bitcoin#7922
- bitcoin/bitcoin#7825
- bitcoin/bitcoin#8317
- bitcoin/bitcoin#9804
- Only the commit that changed `base58.cpp`
Precursor to #3202 .
6 years ago
23f8b30c88
Auto merge of #3193 - str4d:b9856-badalloc-terminate, r=bitcartel
Terminate immediately when allocation fails
Backport of bitcoin/bitcoin#9856
Closes #1498 .
6 years ago
54a872f0fa
Fix undefined behaviour, calling memcpy with NULL pointer.
Identified as part of audit: Least Authority, Issue D.
6 years ago
9bd8f092c6
Closes #3178 by adding verbosity level improvements to getblock RPC.
This is a follow-up commit for d0a1d833520d120bb5a2ac4cf4192047af6afe24
found in PR #3095 in order to fix nits and add a test.
6 years ago
bf911b3038
Tweaks to d0a1d83 to complete backport of Bitcoin PR #8704
6 years ago
eb78a45a0c
Backported Bitcoin PR #8704 to optionally return full tx details in the getblock rpc call
6 years ago
b300118002
Merge pull request #2813 from str4d/2074-uacomment
Implement uacomment config parameter
6 years ago
debf6af9f8
Move memo member varible from SproutNotePlaintext to BaseNotePlaintext.
Add memo() accessor to BaseNotePlaintext.
6 years ago
d266f40393
Create class hierarchy for SproutNotePlaintext.
BaseNotePlaintext contains member variable for common attribute, value.
6 years ago
5020a93631
Refactoring: rename NotePlaintext --> SproutNotePlaintext
Also renames:
CNotePlaintextEntry --> CSproutNotePlaintextEntry
CUnspentNotePlaintextEntry --> CUnspentSproutNotePlaintextEntry
6 years ago
9354f8e568
Remove unused SproutNote variables.
6 years ago
5f4fa1a954
Add virtual destructor to SproutNote and BaseNote
Also add test to make sure default copy constructors are okay.
6 years ago
5d99e3e92f
Refactoring: SproutNote member variable value moved to BaseNote.
All notes have a value, so the member variable has been moved to the
base class, and direct member access has been replaced with a getter.
6 years ago
812098256f
Coinbase transactions can not have shielded spend or output
6 years ago
4b4662b06d
Make sure transactions have non-empty outputs
6 years ago
a2ff78620a
Auto merge of #3191 - Eirik0:3057-sapling-nullifier-set, r=str4d
Add sapling nullifier set
PR for https://github.com/zcash/zcash/issues/3057
6 years ago
aeb089ecc7
Attempt to log before terminating if prevector allocation fails
6 years ago
Sean Bowe