hush
/
hush3
9
0
Fork 11
Code Issues 140 Pull Requests 2 Projects Releases 16 Wiki Activity
Labels Milestones
New Issue

hush-cli abortrescan does not stop "Building Witnesses" #331

Open
opened 7 months ago by duke · 3 comments
duke commented 7 months ago
Owner

Originally this was part of #330 but it's been carved off to this.

The internals of hushd should consider "Building Witnesses" to be part of a rescan. This is the function BuildWitnessCache in src/wallet/wallet.cpp . The same function is called every time a tx in a block is detected to have one of our addresses or after the chain syncs initially to build witnesses for all time. When abortrescan code was merged from BTC it never touched this code because there is no concept of zaddr witnesses in BTC, so this function was not considered part of the rescan.

Originally this was part of #330 but it's been carved off to this. The internals of hushd should consider "Building Witnesses" to be part of a rescan. This is the function `BuildWitnessCache` in src/wallet/wallet.cpp . The same function is called every time a tx in a block is detected to have one of our addresses or after the chain syncs initially to build witnesses for all time. When `abortrescan` code was merged from BTC it never touched this code because there is no concept of zaddr witnesses in BTC, so this function was not considered part of the rescan.
duke added the
bug
 label 7 months ago
duke commented 7 months ago
Poster
Owner

Potentially fixed by 4642a35f06 on dev , needs testing

Potentially fixed by 4642a35f06ba6e8de0d238d96771a3263ab31a2a on dev , needs testing
duke added this to the 3.10.0 milestone 6 months ago
duke commented 6 months ago
Poster
Owner

This needs testing before the 3.10.0 release

This needs testing before the 3.10.0 release
duke removed this from the 3.10.0 milestone 5 months ago
duke commented 5 months ago
Poster
Owner

Removed this from the 3.10.0 milestone, it was not important enough to block the release any longer. It's not a feature that most people will use and SD does not use it.

Removed this from the 3.10.0 milestone, it was not important enough to block the release any longer. It's not a feature that most people will use and SD does not use it.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
arm
asyncnotedecryption
danger
dev
dev-aarch64
dev-mac
dev-old-randomx
divzaddrs
dragonx
duke
freebsd
getfilterednotes
hip39
insync
jahway603
master
mvstuff
onryo
p2p_privacy
ramhash
relaytx
rx-largepages
setbestchain
warmup
witness_cache
wolfssl
wolfssl_win
z_createrawtransaction
z_importwallet
z_signmessage
Labels
Apply labels
Clear labels
0-500 bounty
bounty up to 500 HUSH 2001-5000 bounty
bounty between 2001 and 5000 HUSH 501-2000 bounty
bounty between 501 and 2000 HUSH arm
something doesn't work on arm beginners
for new developers bug
may or may not be a bug build
problems building documentation
not enough information feature
new feature high priority
high priority i2p
related to i2p low priority
low priority medium priority
medium priority question
something is not clear release
release label or issue related to it testing
related to testing tor
related to tor wontfix
this won't be fixed
No Label 0-500 bounty 2001-5000 bounty 501-2000 bounty arm beginners bug build documentation feature high priority i2p low priority medium priority question release testing tor wontfix
Milestone
Set milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Assign users
Clear assignees
No Assignees
1 Participants
Notifications
Due Date

No due date set.

Dependencies

This issue currently doesn't have any dependencies.

Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch '%!s(MISSING)'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes