Labels Milestones

finally removing gh links from sdl-cli #6

Merged

jahway603 merged 2 commits from jahway603/silentdragonlite-cli:dev into dev-2021 3 years ago

Conversation 4 Commits 2 Files Changed 1

jahway603 commented 3 years ago

Collaborator

There is no content yet.

jahway603 added 2 commits 3 years ago

348258faef converted old repo links from gh to hush gitea

8565aa50e1 Merge pull request 'idk why the old gh links were never changed' (#1) from master into dev

Reviewed-on: https://git.hush.is/jahway603/silentdragonlite-cli/pulls/1

jahway603 merged commit 8d785d708a into dev-2021 3 years ago

jahway603 referenced this issue from a commit 3 years ago

Merge pull request 'finally removing gh links from sdl-cli' (#6) from jahway603/silentdragonlite-cli:dev into dev-2021

duke commented 3 years ago

Owner

@jahway603 have you tested that this works correctly? It's not clear to me that it does.

If you go to https://git.hush.is/hush/librustzcash.git?rev=1a0204113d487cdaaf183c2967010e5214ff9e37#1a0204113d487cdaaf183c2967010e5214ff9e37 it does not show the 1a020... commit, because Gitea does not seem to interpret the ?rev= URL param the same way as Github.

Our stuff definitely depends on this special comming and many things will break if it's not used.

@jahway603 have you tested that this works correctly? It's not clear to me that it does. If you go to https://git.hush.is/hush/librustzcash.git?rev=1a0204113d487cdaaf183c2967010e5214ff9e37#1a0204113d487cdaaf183c2967010e5214ff9e37 it does not show the 1a020... commit, because Gitea does not seem to interpret the `?rev=` URL param the same way as Github. Our stuff definitely depends on this special comming and many things will break if it's not used.

jahway603 commented 3 years ago

Poster

Collaborator

Reverted back to GH links with their special "?rev" in this pull request here

Possible solutions

• Incorp the right commits from these 100+ located here

• Figure out how to do special commit on Gitea with their "?rev"-equivalent

Reverted back to GH links with their special "?rev" [in this pull request here](https://git.hush.is/hush/silentdragonlite-cli/pulls/9) **Possible solutions** * Incorp the right commits from [these 100+ located here](https://git.hush.is/hush/librustzcash/commits/commit/c62503416377eb31fb74cbbcd4db91206df561fb) * Figure out how to do special commit on Gitea with their "?rev"-equivalent

duke commented 3 years ago

Owner

@jahway603 another way to solve this would be to tell Cargo.lock to use the sdl branch which that commit corresponds to

@jahway603 another way to solve this would be to tell Cargo.lock to use the `sdl` branch which that commit corresponds to

duke commented 3 years ago

Owner

@jahway603 when I look at https://github.com/MyHush/librustzcash?rev=1a0204113d487cdaaf183c2967010e5214ff9e37 it also does not show me that commit in the web interface. I am not sure if that rev= param is only used by Cargo maybe?

@jahway603 when I look at https://github.com/MyHush/librustzcash?rev=1a0204113d487cdaaf183c2967010e5214ff9e37 it also does not show me that commit in the web interface. I am not sure if that `rev=` param is only used by Cargo maybe?

duke referenced this issue from a commit 4 months ago

Merge pull request 'pull hush/dev' (#6) from hush/silentdragonlite-cli:dev into dev

The pull request has been merged as 8d785d708a.

Sign in to join this conversation.

Reviewers

Request review

No reviewers

Labels

Apply labels

Clear labels

No items

No Label

Milestone

Set milestone

Clear milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Assign users

Clear assignees

No Assignees

2 Participants

Notifications

Subscribe

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Write Preview

Loading…

Cancel

Save

There is no content yet.