Gavin Andresen
b97d54355e
Merge pull request #1106 from jgarzik/sign-compare
Fix many sign-comparison warnings found in bitcoin codebase
12 years ago
Gavin Andresen
e873dc654c
Merge pull request #1115 from laanwj/2012_04_cleanupmisc
Delete unused, unreachable and commented code, add missing initializer
12 years ago
Jeff Garzik
ce8c93498a
main.cpp: replace tabs with spaces
Sometimes they sneak in through the 'vi' door
12 years ago
Jeff Garzik
8bff8ac079
AlreadyHave(): only hold lock during mapTransactions access
12 years ago
Wladimir J. van der Laan
7fa3ad83a9
Remove unused and unreachable code
12 years ago
Wladimir J. van der Laan
4941aad657
Add forgotten initializer
12 years ago
Jeff Garzik
dd21ce5f1b
Merge pull request #1094 from jgarzik/already-have-locking
Locking fix for AlreadyHave()
12 years ago
Jeff Garzik
ea9627979e
Bump PROTOCOL_VERSION to 60001, thereby enabling BIP31
12 years ago
Jeff Garzik
865a0c1674
Merge pull request #1081 from jgarzik/pong
BIP 0031: pong message
12 years ago
Wladimir J. van der Laan
7a5452ffb3
Merge pull request #1092 from laanwj/2012_04_sendcoins_setlabelfix
When sending coins, set label when selecting address that already has a label
12 years ago
Wladimir J. van der Laan
088a13331b
Merge pull request #1091 from Diapolo/GUI-BlockDL
revert to default OS theme for progressbar (fix #1071 )
12 years ago
Jeff Garzik
9fb89c26f3
Fix misc. minor sign-comparison warnings
12 years ago
Jeff Garzik
0dd710acb6
CNode's nHeaderStart may be negative, so change its type
12 years ago
Jeff Garzik
c3fad8350b
serialize.h: CAutoFile's read and write may take size_t nSize
12 years ago
Jeff Garzik
3a78f82a78
Fix sign-compare warnings: netbase's Lookup* max-solutions may be unsigned
12 years ago
Jeff Garzik
c376ac359e
Fix loop index var types, fixing many minor sign comparison warnings
foo.size() typically returns an unsigned integral type; make loop variables
match those types' signedness.
12 years ago
Jeff Garzik
ab9dc75a18
The string class returns string::npos, when find() fails.
Noticed when sign-comparison warnings were enabled.
12 years ago
Jeff Garzik
5a701eb7ea
Merge pull request #1104 from laanwj/2012_04_clang
Enable and fix most compilation warnings
12 years ago
Jeff Garzik
fced2231f8
Merge pull request #1084 from dooglus/validate_secret
importprivkey doesn't check that it is given a private key
12 years ago
Wladimir J. van der Laan
9ea8e60a0c
Merge pull request #1097 from laanwj/2012_04_runawayexception
Show a message box when runaway exception happens
12 years ago
Jeff Garzik
c99ddfaa22
Merge pull request #1100 from luke-jr/qrcode_errchk
Bugfix: Check that QRcode_encodeString didn't return NULL (error)
12 years ago
Wladimir J. van der Laan
da7bbd9dfd
fix warnings: suggest explicit braces to avoid ambiguous 'else' [-Wparentheses]
12 years ago
Wladimir J. van der Laan
6642ffb761
fix warnings: '&&' within '||' [-Wlogical-op-parentheses]
12 years ago
Wladimir J. van der Laan
2e120f28e0
fix warnings: delete called on 'XX' that has virtual functions but non-virtual destructor [-Wdelete-non-virtual-dtor]
12 years ago
Wladimir J. van der Laan
11cd416525
fix warnings: unused variable 'XX' [-Wunused-variable]
12 years ago
Wladimir J. van der Laan
76d8170ce8
fix warnings: enumeration values 'XX' not handled in switch [-Wswitch-enum]
12 years ago
Wladimir J. van der Laan
87207a2e08
fix warnings: 'XX' defined as a struct here but previously declared as a class [-Wmismatched-tags]
12 years ago
Wladimir J. van der Laan
8add7822ce
fix warnings: array subscript is of type 'char' [-Wchar-subscripts]
12 years ago
Wladimir J. van der Laan
1f29d399f4
work around issue in boost::program_options that prevents from compiling in clang
12 years ago
Wladimir J. van der Laan
f9f625fb32
enable all warnings except invalid-offsetof, sign-compare, unused-parameter
12 years ago
Luke Dashjr
2eb665c634
Bugfix: Check that QRcode_encodeString didn't return NULL (error)
Without this, any error will segfault Bitcoin-Qt
12 years ago
Wladimir J. van der Laan
a7a0c7a1bf
Show a message box when runaway exception happens
This is more clear to users than when the program simply disappears (usually during initialization). It still logs the message to the console and debug log as well.
12 years ago
Wladimir J. van der Laan
6f6f524f1a
Rename make_windows_icon.py to .sh as it is a shell script ( fixes #1099 )
12 years ago
Jeff Garzik
22014c31e5
Merge pull request #1093 from jgarzik/tx-opt
Database micro-optimization for "tx" network message
12 years ago
Wladimir J. van der Laan
46ba858817
Merge pull request #1089 from laanwj/2012_04_translationupdate
Update translations for bitcoin core
12 years ago
Wladimir J. van der Laan
3fddc8effc
Update translations for bitcoin core
- Move scripts/qt to share/qt, to clean up toplevel directories
- Update english ts file which is used to source messages for Transifex
- In extract_strings_qt.py use a glob *.h *.cpp, this is safe now that the Wx UI files are removed
12 years ago
Wladimir J. van der Laan
c1d0547cf6
Merge pull request #1096 from laanwj/2012_04_tick
Do not show green tick unless all known blocks are downloaded (fixes #921 )
12 years ago
Wladimir J. van der Laan
b970067298
Do not show green tick unless all known blocks are downloaded ( fixes #921 )
12 years ago
Jeff Garzik
8deb9822e4
Locking fix for AlreadyHave()
Access to mapTransactions[] must be guarded by cs_mapTransactions lock.
Also, reformat long lines to make the switch statement more readable.
12 years ago
Jeff Garzik
9925d34a49
Database micro-optimization for "tx" network message
Open database once per "tx" message, rather than multiple times,
in the case of orphan transaction presence.
As a side effect, a now-unused CTransaction::AcceptToMemoryPool()
variant is removed.
12 years ago
Wladimir J. van der Laan
2d67195ed2
Set label when selecting an address that already has a label. Fixes #1080 .
12 years ago
Philip Kaufmann
e72c6a1830
revert to default OS theme for progressbar / fix small glitches in bitcoingui.cpp
12 years ago
Wladimir J. van der Laan
6b8e7eefcc
Add missing tooltip and key shortcut in settings dialog ( #1088 without line break part)
12 years ago
Gavin Andresen
c3c203ccd9
Merge pull request #1087 from sipa/fix_1086
Fix #1086 : add /testnet to passed datadir
12 years ago
Pieter Wuille
7a743148c9
Fix #1086 : add /testnet to passed datadir
12 years ago
Jeff Garzik
8b09cd3a4d
Replace several network protocol version numbers with named constants
stored in version.h.
Also, a minor CAddress code reformat while we're in there, fixing
some incorrect indentation.
12 years ago
Chris Moore
b3a6e613fc
CBitcoinSecret::SetString() now calls IsValid() to make sure it was passed something with the correct version.
12 years ago
Gavin Andresen
b7dc02381f
Merge pull request #1041 from gavinandresen/listtransactionsfix
Bug fix listtransactions from/count handling.
12 years ago
Wladimir J. van der Laan
181400c3d5
make text in about box selectable ( fixes #1055 )
12 years ago
Wladimir J. van der Laan
d844cb58a8
Merge pull request #1078 from Diapolo/QR-Code
QR-Code code update
Fixes problems reported on forum: https://bitcointalk.org/index.php?topic=73695.msg839804#msg839804
12 years ago