Add new checkpoints #91

Closed
opened 2 years ago by duke · 11 comments
duke commented 2 years ago
Owner

Now that it's documented in our release process, it should be much easier.

Now that it's documented in our release process, it should be much easier.
Collaborator

I generated checkpoints but it looks like aes 0.3.2 has been yanked similar to older version paper wallet was using:
https://crates.io/crates/aes/0.3.2

I get this on cargo update
error: failed to select a version for the requirement 'aes = "^0.3"'

Not sure if helpful, but found you can still download yanked crates like this:
https://crates.io/api/v1/crates/aes/0.3.2/download

Potential work-around is to cargo vendor

I generated checkpoints but it looks like aes 0.3.2 has been yanked similar to older version paper wallet was using: https://crates.io/crates/aes/0.3.2 I get this on cargo update `error: failed to select a version for the requirement 'aes = "^0.3"'` Not sure if helpful, but found you can still download yanked crates like this: https://crates.io/api/v1/crates/aes/0.3.2/download Potential work-around is to `cargo vendor`
Collaborator

cargo vendor /home/user/vendor does seem to work and downloads all the correct versions locally to path provided.

You then add something like this to .cargo/config.toml

[source.crates-io]
replace-with = "vendored-sources"

[source.vendored-sources]
directory = "vendor"

I may have done something else wrong because I'm still syncing from old check point after building again. This is in Cargo.lock:

[[package]]
name = "silentdragonlitelib"
version = "0.1.0"
source = "git+https://git.hush.is/hush/silentdragonlite-cli?rev=f48967342b1fb398b3b8b96464db1acd251ce92f#f48967342b1fb398b3b8b96464db1acd251ce92f"

This was commit for updated checkpoints on dev branch:
f48967342b

`cargo vendor /home/user/vendor` does seem to work and downloads all the correct versions locally to path provided. You then add something like this to .cargo/config.toml ``` [source.crates-io] replace-with = "vendored-sources" [source.vendored-sources] directory = "vendor" ``` I may have done something else wrong because I'm still syncing from old check point after building again. This is in Cargo.lock: ``` [[package]] name = "silentdragonlitelib" version = "0.1.0" source = "git+https://git.hush.is/hush/silentdragonlite-cli?rev=f48967342b1fb398b3b8b96464db1acd251ce92f#f48967342b1fb398b3b8b96464db1acd251ce92f" ``` This was commit for updated checkpoints on dev branch: https://git.hush.is/hush/silentdragonlite-cli/commit/f48967342b1fb398b3b8b96464db1acd251ce92f
Collaborator

It may have been because I had an existing wallet that wasn't fully synced. When I deleted wallet and restored from seed, it started syncing from new checkpoint height.

It may have been because I had an existing wallet that wasn't fully synced. When I deleted wallet and restored from seed, it started syncing from new checkpoint height.
Poster
Owner

@fekt you made serious progress! I think we should have this vendor directory in our repo, can you make a ./vendor directory in this repo and update Cargo.toml to use that?

@fekt you made serious progress! I think we should have this vendor directory in our repo, can you make a ./vendor directory in this repo and update Cargo.toml to use that?
Collaborator

@fekt thanks for finding this cargo vendor info as I'm glad to hear that rust has this feature.

@fekt thanks for finding this `cargo vendor` info as I'm glad to hear that rust has this feature.
Poster
Owner

Official cargo vendor docs are here: https://doc.rust-lang.org/cargo/commands/cargo-vendor.html

Official cargo vendor docs are here: https://doc.rust-lang.org/cargo/commands/cargo-vendor.html
Poster
Owner

Also, if we get this working correctly, it seems we can do the same idea with SDP and get that working again.

Also, if we get this working correctly, it seems we can do the same idea with SDP and get that working again.
Collaborator

@fekt you made serious progress! I think we should have this vendor directory in our repo, can you make a ./vendor directory in this repo and update Cargo.toml to use that?

I'll try this later or over the weekend. I haven't checked documentation but there's probably an option to exclude specific packages from being vendored. Otherwise it will vendor the couple of repos we reference or have already. It will give you what to put in Cargo.toml and can just not include those as vendored packages so it still downloads those packages from repos. I was getting some error related to a blake package at one point but didn't make note of it. Seemed to have resolved itself either by using all vendored packages or excluding the couple of repos we reference.

> @fekt you made serious progress! I think we should have this vendor directory in our repo, can you make a ./vendor directory in this repo and update Cargo.toml to use that? I'll try this later or over the weekend. I haven't checked documentation but there's probably an option to exclude specific packages from being vendored. Otherwise it will vendor the couple of repos we reference or have already. It will give you what to put in Cargo.toml and can just not include those as vendored packages so it still downloads those packages from repos. I was getting some error related to a blake package at one point but didn't make note of it. Seemed to have resolved itself either by using all vendored packages or excluding the couple of repos we reference.
Collaborator

I think the vendored crates may need to stay local just due to differences there would be in environments. You have to modify .cargo/config.toml and not Cargo.toml

I tried cargo vendor on dev branch of SilentDragonPaper, but get these errors:

found duplicate version of package `blake2-rfc v0.2.18` vendored from two sources:

source 1: https://git.hush.is/hush/blake2-rfc?rev=04e586d640f87f35e7c07100508216ca7797195c#04e586d6
source 2: https://git.hush.is/hush/blake2-rfc?rev=ba06a506baa297d37959d5e13e90008bba12ec60#ba06a506
I think the vendored crates may need to stay local just due to differences there would be in environments. You have to modify .cargo/config.toml and not Cargo.toml I tried cargo vendor on dev branch of SilentDragonPaper, but get these errors: ``` found duplicate version of package `blake2-rfc v0.2.18` vendored from two sources: source 1: https://git.hush.is/hush/blake2-rfc?rev=04e586d640f87f35e7c07100508216ca7797195c#04e586d6 source 2: https://git.hush.is/hush/blake2-rfc?rev=ba06a506baa297d37959d5e13e90008bba12ec60#ba06a506 ```
Poster
Owner

@fekt those 2 different commits of blake2-rfc are just changing the license and download URL, otherwise they are identical code. They can both be 04e586d640

@fekt those 2 different commits of blake2-rfc are just changing the license and download URL, otherwise they are identical code. They can both be `04e586d640`
duke commented 1 year ago
Poster
Owner

we have even newer checkpoints from @onryo, closing

we have even newer checkpoints from @onryo, closing
duke closed this issue 1 year ago
Sign in to join this conversation.
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date

No due date set.

Dependencies

This issue currently doesn't have any dependencies.

Loading…
There is no content yet.