hush
/
SilentDragonLite
9
1
Fork 4
Code Issues 38 Pull Requests Projects Releases 8 Wiki Activity
Labels Milestones

Add custom Fee, fix a problem with isOnline in getsettings, note Automation only for chat related tx #146

Merged
duke merged 4 commits from lucretius/SilentDragonLite:dev into dev 3 months ago
Conversation 1 Commits 4 Files Changed 11
lucretius commented 3 months ago
Collaborator

This PR adds the option to use a custom fee for transactions.

  • Checkbox on the Sentab has been added.

  • The field "mining fee" is only writable if the box is checked, otherwise it is read only and the default fee is used.

  • Added a note on the tx confirmation window if a custom fee is used.

It also fixes a problem with the bool isOnline where there was one too many data formats.

Also the note Automation only triggers now for chat related tx.

This PR adds the option to use a custom fee for transactions. - Checkbox on the Sentab has been added. - The field "mining fee" is only writable if the box is checked, otherwise it is read only and the default fee is used. - Added a note on the tx confirmation window if a custom fee is used. It also fixes a problem with the bool isOnline where there was one too many data formats. Also the note Automation only triggers now for chat related tx.
👍 1
lucretius added 4 commits 3 months ago
lucretius changed title from Add custom Fee, fix a problem with isOnline in getsettings to Add custom Fee, fix a problem with isOnline in getsettings, note Automation only for chat related tx 3 months ago
duke merged commit e299fe33e9 into dev 3 months ago
duke commented 3 months ago
Owner

@lucretius looks good, thank you. I think we may want to add a "sanity check" for custom fees, for the case when a user probably makes a typo for the fee. For example, if the user wants to use a fee which is larger than the amount being sent (in the case where the amount being sent is non-zero and above the default fee), there should be a popup that says "Are you really sure about that?" or something like that.

@lucretius looks good, thank you. I think we may want to add a "sanity check" for custom fees, for the case when a user probably makes a typo for the fee. For example, if the user wants to use a fee which is larger than the amount being sent (in the case where the amount being sent is non-zero and above the default fee), there should be a popup that says "Are you really sure about that?" or something like that.
👍 1
The pull request has been merged as e299fe33e9.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
Labels
Apply labels
Clear labels
0-500 bounty
bounty up to 500 HUSH 2001-5000 bounty
bounty between 2001 and 5000 HUSH 501-2000 bounty
bounty between 501 and 2000 HUSH arm
something doesn't work on arm beginners
for new developers bug
may or may not be a bug build
problems building documentation
not enough information feature
new feature high priority
high priority i2p
related to i2p low priority
low priority medium priority
medium priority question
something is not clear release
release label or issue related to it tor
related to tor translation
translation update windows
related to windows wontfix
this won't be fixed
No Label 0-500 bounty 2001-5000 bounty 501-2000 bounty arm beginners bug build documentation feature high priority i2p low priority medium priority question release tor translation windows wontfix
Milestone
Set milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Assign users
Clear assignees
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'lucretius/SilentDragonLite:dev'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes