Move connection errror to status Bar #148
Merged
duke
merged 4 commits from lucretius/SilentDragonLite:dev
into dev
3 months ago
Loading…
Reference in new issue
There is no content yet.
Delete Branch 'lucretius/SilentDragonLite:dev'
Deleting a branch is permanent. It CANNOT be undone. Continue?
This PR will move connection errors to the status bar and update the lib to not show the seed in stdout.
@lucretius do we want to move all connection errors to the status bar or only "compression flag" errors?
Our current code uses the status bar for informational updates, and any errors will create a popup with the error message. That makes debugging things easier and tells the user there is a problem. This code change means all connection errors will be rendered in the status bar and be very easy to miss (if you are not looking at the screen for 5 seconds) and makes some things a lot harder to debug.
With this new code, if a user hits a real connection error, their node will be stuck and if they didn't happen to be looking at the screen during the 5 seconds that it happened, they will have no idea why. It's also almost impossible for a user to get a screenshot of the statusbar within 5 seconds to report an issue.
What we talked about was only moving the compression flag error to the status bar, because it's basically an ignorable error that the user doesn't need to know about. To do that, you can inspect the error message and see if the word
compression
appears and only render it in the status bar in that case, otherwise do the previous behavior.I changed it, so that only connection errors that contains "compression" will move to the status bar.
c73ac543f4
into dev 3 months ago@lucretius awesome, thanks for working on this!
c73ac543f4
.